added to catalog layout for consistent levels #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
reviewed
Feb 24, 2021
best-practices.md
Outdated
| 5. Items should be stored in subdirectories of their parent catalog. | ||
| This means that each item and its assets are contained in a unique subdirectory. | ||
| 6. Limit the number of items in a catalog or sub-catalog, grouping / partitioning as relevant to the dataset. | ||
| 7. In a nested hierarchy of catalogs and collections make the different levels 'homogeneous' - all catalogs or all collections. |
Collaborator
There was a problem hiding this comment.
That sounds a bit like there should be only one level of collections, although it should also be fine to have e.g. all levels being collections (although an Item can only link to one collection).
Contributor
Author
There was a problem hiding this comment.
Cool, I'll try again. I was thinking about that as I was writing it but didn't manage to find a way to succinctly get it across. This was weirdly more challenging to explain than I was expecting.
Contributor
Author
|
Ok, new attempt is up. |
lossyrob
approved these changes
Mar 2, 2021
Contributor
lossyrob
left a comment
lossyrob
left a comment
There was a problem hiding this comment.
Suggested some wording changes to make it a bit more clear.
Co-authored-by: Rob Emanuele <[email protected]>
m-mohr
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #949
Proposed Changes:
PR Checklist: